libsurfer/translation/

mod.rs

use std::collections::HashMap;
#[cfg(not(target_arch = "wasm32"))]
use std::path::Path;
use std::sync::Arc;
use std::sync::mpsc::Sender;

use ecolor::Color32;
use eyre::Result;
#[cfg(not(target_arch = "wasm32"))]
use toml::Table;
#[cfg(not(target_arch = "wasm32"))]
use tracing::warn;

mod basic_translators;
pub mod clock;
mod color_translators;
mod enum_translator;
mod event_translator;
mod fixed_point;
mod instruction_translators;
mod mapping_translators;
pub mod numeric_translators;
#[cfg(feature = "python")]
mod python_translators;
#[cfg(all(not(target_arch = "wasm32"), feature = "wasm_plugins"))]
pub mod wasm_translator;

pub use basic_translators::*;
use clock::ClockTranslator;
use event_translator::EventTranslator;
#[cfg(not(target_arch = "wasm32"))]
use instruction_decoder::Decoder;
pub use instruction_translators::*;
use itertools::Itertools;
pub use numeric_translators::*;
use surfer_translation_types::{
    BasicTranslator, HierFormatResult, SubFieldFlatTranslationResult, TranslatedValue,
    TranslationPreference, TranslationResult, Translator, ValueKind, ValueRepr, VariableEncoding,
    VariableInfo, VariableValue,
};

use crate::config::SurferTheme;
use crate::translation::enum_translator::EnumTranslator;
use crate::wave_container::{ScopeId, VarId};
use crate::{message::Message, wave_container::VariableMeta};

pub type DynTranslator = dyn Translator<VarId, ScopeId, Message>;
pub type DynBasicTranslator = dyn BasicTranslator<VarId, ScopeId>;

#[cfg(not(target_arch = "wasm32"))]
static DECODERS_DIR: &str = "decoders";

#[cfg(not(target_arch = "wasm32"))]
static MAPPINGS_DIR: &str = "mappings";

fn translate_with_basic(
    t: &DynBasicTranslator,
    variable: &VariableMeta,
    value: &VariableValue,
) -> Result<TranslationResult> {
    let (val, kind) = t.basic_translate(variable.num_bits.unwrap_or(0), value);
    Ok(TranslationResult {
        val: ValueRepr::String(val),
        kind,
        subfields: vec![],
    })
}

#[derive(Clone)]
pub enum AnyTranslator {
    Full(Arc<DynTranslator>),
    Basic(Arc<DynBasicTranslator>),
    #[cfg(feature = "python")]
    Python(Arc<python_translators::PythonTranslator>),
}

impl AnyTranslator {
    #[must_use]
    pub fn is_basic(&self) -> bool {
        matches!(self, AnyTranslator::Basic(_))
    }
}

impl Translator<VarId, ScopeId, Message> for AnyTranslator {
    fn name(&self) -> String {
        match self {
            AnyTranslator::Full(t) => t.name(),
            AnyTranslator::Basic(t) => t.name(),
            #[cfg(feature = "python")]
            AnyTranslator::Python(t) => t.name(),
        }
    }

    fn set_wave_source(&self, wave_source: Option<surfer_translation_types::WaveSource>) {
        match self {
            AnyTranslator::Full(translator) => translator.set_wave_source(wave_source),
            AnyTranslator::Basic(_) => {}
            #[cfg(feature = "python")]
            AnyTranslator::Python(_) => {}
        }
    }

    fn translate(
        &self,
        variable: &VariableMeta,
        value: &VariableValue,
    ) -> Result<TranslationResult> {
        match self {
            AnyTranslator::Full(t) => t.translate(variable, value),
            AnyTranslator::Basic(t) => translate_with_basic(&**t, variable, value),
            #[cfg(feature = "python")]
            AnyTranslator::Python(t) => translate_with_basic(&**t, variable, value),
        }
    }

    fn variable_info(&self, variable: &VariableMeta) -> Result<VariableInfo> {
        match self {
            AnyTranslator::Full(t) => t.variable_info(variable),
            AnyTranslator::Basic(t) => t.variable_info(variable),
            #[cfg(feature = "python")]
            #[cfg(target_family = "unix")]
            AnyTranslator::Python(t) => t.variable_info(variable),
        }
    }

    fn translates(&self, variable: &VariableMeta) -> Result<TranslationPreference> {
        match self {
            AnyTranslator::Full(t) => t.translates(variable),
            AnyTranslator::Basic(t) => t.translates(variable),
            #[cfg(feature = "python")]
            AnyTranslator::Python(t) => t.translates(variable),
        }
    }

    fn reload(&self, sender: Sender<Message>) {
        match self {
            AnyTranslator::Full(t) => t.reload(sender),
            AnyTranslator::Basic(_) => (),
            #[cfg(feature = "python")]
            AnyTranslator::Python(_) => (),
        }
    }

    fn variable_name_info(
        &self,
        variable: &surfer_translation_types::VariableMeta<VarId, ScopeId>,
    ) -> Option<surfer_translation_types::translator::VariableNameInfo> {
        match self {
            AnyTranslator::Full(translator) => translator.variable_name_info(variable),
            AnyTranslator::Basic(_) => None,
            #[cfg(feature = "python")]
            AnyTranslator::Python(_) => None,
        }
    }

    fn translate_numeric(&self, variable: &VariableMeta, value: &VariableValue) -> Option<f64> {
        match self {
            AnyTranslator::Full(t) => t.translate_numeric(variable, value),
            AnyTranslator::Basic(t) => {
                t.basic_translate_numeric(variable.num_bits.unwrap_or(0), value)
            }
            #[cfg(feature = "python")]
            AnyTranslator::Python(t) => {
                t.basic_translate_numeric(variable.num_bits.unwrap_or(0), value)
            }
        }
    }
}

/// Look inside the config directory and inside "$(cwd)/.surfer" for user-defined decoders
/// To add a new decoder named 'x', add a directory 'x' to the decoders directory
/// Inside, multiple toml files can be added which will all be used for decoding 'x'
/// This is useful e.g., for layering RISC-V extensions
#[cfg(not(target_arch = "wasm32"))]
fn find_user_decoders() -> Vec<Arc<DynBasicTranslator>> {
    let mut decoders: Vec<Arc<DynBasicTranslator>> = vec![];
    if let Some(proj_dirs) = crate::config::PROJECT_DIR.as_ref() {
        let mut config_decoders = find_user_decoders_at_path(proj_dirs.config_dir());
        decoders.append(&mut config_decoders);
    }

    let mut project_decoders = find_user_decoders_at_path(Path::new(crate::config::LOCAL_DIR));
    decoders.append(&mut project_decoders);

    decoders
}

/// Look for user defined decoders in path.
#[cfg(not(target_arch = "wasm32"))]
fn find_user_decoders_at_path(path: &Path) -> Vec<Arc<DynBasicTranslator>> {
    use tracing::{error, info};

    let mut decoders: Vec<Arc<DynBasicTranslator>> = vec![];
    let p = path.join(DECODERS_DIR);
    info!("Looking for user decoders at {}", p.display());
    let Ok(decoder_dirs) = std::fs::read_dir(p) else {
        return decoders;
    };

    for decoder_dir in decoder_dirs.flatten() {
        if decoder_dir.metadata().is_ok_and(|m| m.is_dir()) {
            let Ok(name) = decoder_dir.file_name().into_string() else {
                warn!("Cannot load decoder. Invalid name.");
                continue;
            };
            let mut tomls = vec![];
            // Keeps track of the bit width of the first parsed toml
            // All tomls must use the same width
            let mut width: Option<toml::Value> = None;

            if let Ok(toml_files) = std::fs::read_dir(decoder_dir.path()) {
                for toml_file in toml_files.flatten() {
                    if toml_file
                        .file_name()
                        .into_string()
                        .is_ok_and(|file_name| file_name.ends_with(".toml"))
                    {
                        let Ok(text) = std::fs::read_to_string(toml_file.path()) else {
                            warn!(
                                "Skipping toml file {}. Cannot read file.",
                                toml_file.path().display()
                            );
                            continue;
                        };

                        let Ok(toml_parsed) = text.parse::<Table>() else {
                            warn!(
                                "Skipping toml file {}. Cannot parse toml.",
                                toml_file.path().display()
                            );
                            continue;
                        };

                        let Some(toml_width) = toml_parsed.get("width") else {
                            warn!(
                                "Skipping toml file {}. Mandatory key 'width' is missing.",
                                toml_file.path().display()
                            );
                            continue;
                        };

                        if width.clone().is_some_and(|width| width != *toml_width) {
                            warn!(
                                "Skipping toml file {}. Bit widths do not match.",
                                toml_file.path().display()
                            );
                            continue;
                        }
                        width = Some(toml_width.clone());

                        tomls.push(toml_parsed);
                    }
                }
            }

            if let Some(width) = width.and_then(|width| width.as_integer()) {
                match Decoder::new_from_table(tomls) {
                    Ok(decoder) => {
                        let translator = InstructionTranslator {
                            name,
                            decoder,
                            num_bits: width.unsigned_abs() as u32,
                        };
                        tracing::info!(
                            "Loaded {}-bit instruction decoder: {} ",
                            width.unsigned_abs(),
                            translator.name(),
                        );
                        decoders.push(Arc::new(translator));
                    }
                    Err(e) => {
                        error!("Error while building decoder {name}");
                        for toml in e {
                            for error in toml {
                                error!("{error}");
                            }
                        }
                    }
                }
            }
        }
    }
    decoders
}

/// Look inside the config directory and inside "$(cwd)/.surfer" for user-defined mapping translators
/// To add a new mapping translator named 'x', add a file 'x' to the mapping translators directory
#[cfg(not(target_arch = "wasm32"))]
fn find_user_mapping_translators() -> Vec<Arc<DynBasicTranslator>> {
    let mut translators: Vec<Arc<DynBasicTranslator>> = vec![];
    if let Some(proj_dirs) = &*crate::config::PROJECT_DIR {
        let mut config_decoders = find_user_mapping_translators_at_path(proj_dirs.config_dir());
        translators.append(&mut config_decoders);
    }

    let mut project_decoders =
        find_user_mapping_translators_at_path(Path::new(crate::config::LOCAL_DIR));
    translators.append(&mut project_decoders);

    translators
}

/// Look for user defined mapping translators in path.
#[cfg(not(target_arch = "wasm32"))]
fn find_user_mapping_translators_at_path(path: &Path) -> Vec<Arc<DynBasicTranslator>> {
    let mut mapping_translators: Vec<Arc<DynBasicTranslator>> = vec![];
    let p = path.join(MAPPINGS_DIR);
    tracing::info!("Looking for user mapping translators at {}", p.display());
    let Ok(mapping_files) = std::fs::read_dir(p) else {
        return mapping_translators;
    };

    use crate::translation::mapping_translators::MappingTranslator;
    for mapping_file in mapping_files.flatten() {
        tracing::info!(
            "Found user mapping translator file: {}",
            mapping_file.path().display()
        );
        let Ok(utf8_path) = camino::Utf8PathBuf::try_from(mapping_file.path()) else {
            warn!(
                "Cannot load mapping translator. Path is not valid UTF-8: {}",
                mapping_file.path().display()
            );
            continue;
        };
        let translator = MappingTranslator::new_from_file(utf8_path);
        match translator {
            Err(e) => {
                warn!(
                    "Cannot load mapping translator from file {}: {}",
                    mapping_file.path().display(),
                    e
                );
                continue;
            }
            Ok(translator) => {
                tracing::info!(
                    "Loaded {:?}-bit(s) mapping translator: {}",
                    translator.bits(),
                    translator.name(),
                );
                mapping_translators.push(Arc::new(translator));
            }
        };
    }
    mapping_translators
}

#[must_use]
pub fn all_translators() -> TranslatorList {
    // WASM does not need mut, non-wasm does so we'll allow it
    #[allow(unused_mut)]
    let mut basic_translators: Vec<Arc<DynBasicTranslator>> = vec![
        Arc::new(BitTranslator {}),
        Arc::new(HexTranslator {}),
        Arc::new(OctalTranslator {}),
        Arc::new(GroupingBinaryTranslator {}),
        Arc::new(BinaryTranslator {}),
        Arc::new(ASCIITranslator {}),
        Arc::new(new_rv32_translator()),
        Arc::new(new_rv64_translator()),
        Arc::new(new_mips_translator()),
        Arc::new(new_la64_translator()),
        Arc::new(LebTranslator {}),
        Arc::new(UnsignedTranslator {}),
        Arc::new(SignedTranslator {}),
        Arc::new(SinglePrecisionTranslator {}),
        Arc::new(DoublePrecisionTranslator {}),
        Arc::new(HalfPrecisionTranslator {}),
        Arc::new(BFloat16Translator {}),
        Arc::new(Posit32Translator {}),
        Arc::new(Posit16Translator {}),
        Arc::new(Posit8Translator {}),
        Arc::new(PositQuire8Translator {}),
        Arc::new(PositQuire16Translator {}),
        Arc::new(E5M2Translator {}),
        Arc::new(E4M3Translator {}),
        Arc::new(NumberOfOnesTranslator {}),
        Arc::new(LeadingOnesTranslator {}),
        Arc::new(TrailingOnesTranslator {}),
        Arc::new(LeadingZerosTranslator {}),
        Arc::new(TrailingZerosTranslator {}),
        Arc::new(IdenticalMSBsTranslator {}),
        #[cfg(feature = "f128")]
        Arc::new(QuadPrecisionTranslator {}),
        Arc::new(color_translators::RGBTranslator {}),
        Arc::new(color_translators::GrayScaleTranslator {}),
        Arc::new(color_translators::YCbCrTranslator {}),
    ];

    #[cfg(not(target_arch = "wasm32"))]
    basic_translators.append(&mut find_user_decoders());

    #[cfg(not(target_arch = "wasm32"))]
    basic_translators.append(&mut find_user_mapping_translators());

    TranslatorList::new(
        basic_translators,
        vec![
            Arc::new(ClockTranslator::new()),
            Arc::new(StringTranslator {}),
            Arc::new(EnumTranslator {}),
            Arc::new(UnsignedFixedPointTranslator),
            Arc::new(SignedFixedPointTranslator),
            Arc::new(EventTranslator {}),
        ],
    )
}

#[derive(Default)]
pub struct TranslatorList {
    inner: HashMap<String, AnyTranslator>,
    #[cfg(feature = "python")]
    python_translator: Option<(camino::Utf8PathBuf, String, AnyTranslator)>,
    pub default: String,
}

impl TranslatorList {
    #[must_use]
    pub fn new(basic: Vec<Arc<DynBasicTranslator>>, translators: Vec<Arc<DynTranslator>>) -> Self {
        Self {
            default: "Hexadecimal".to_string(),
            inner: basic
                .into_iter()
                .map(|t| (t.name(), AnyTranslator::Basic(t)))
                .chain(
                    translators
                        .into_iter()
                        .map(|t| (t.name(), AnyTranslator::Full(t))),
                )
                .collect(),
            #[cfg(feature = "python")]
            python_translator: None,
        }
    }

    pub fn all_translator_names(&self) -> Vec<&str> {
        #[cfg(feature = "python")]
        let python_name = self
            .python_translator
            .as_ref()
            .map(|(_, name, _)| name.as_str());
        #[cfg(not(feature = "python"))]
        let python_name = None;
        self.inner
            .keys()
            .map(String::as_str)
            .chain(python_name)
            .collect()
    }

    #[must_use]
    pub fn all_translators(&self) -> Vec<&AnyTranslator> {
        #[cfg(feature = "python")]
        let python_translator = self.python_translator.as_ref().map(|(_, _, t)| t);
        #[cfg(not(feature = "python"))]
        let python_translator = None;
        self.inner.values().chain(python_translator).collect()
    }

    #[must_use]
    pub fn basic_translator_names(&self) -> Vec<&str> {
        self.inner
            .iter()
            .filter_map(|(name, t)| t.is_basic().then_some(name.as_str()))
            .collect()
    }

    #[must_use]
    pub fn get_translator(&self, name: &str) -> &AnyTranslator {
        #[cfg(feature = "python")]
        let python_translator = || {
            self.python_translator
                .as_ref()
                .filter(|(_, python_name, _)| python_name == name)
                .map(|(_, _, t)| t)
        };
        #[cfg(not(feature = "python"))]
        let python_translator = || None;
        self.inner
            .get(name)
            .or_else(python_translator)
            .unwrap_or_else(|| panic!("No translator called {name}"))
    }

    #[must_use]
    pub fn clone_translator(&self, name: &str) -> AnyTranslator {
        self.get_translator(name).clone()
    }

    pub fn add_or_replace(&mut self, t: AnyTranslator) {
        self.inner.insert(t.name(), t);
    }

    #[must_use]
    pub fn is_valid_translator(&self, meta: &VariableMeta, candidate: &str) -> bool {
        self.get_translator(candidate)
            .translates(meta)
            .map(|preference| preference != TranslationPreference::No)
            .unwrap_or(false)
    }

    #[cfg(feature = "python")]
    pub fn load_python_translator(&mut self, filename: camino::Utf8PathBuf) -> Result<()> {
        tracing::debug!("Reading Python code from disk: {filename}");
        let code = std::ffi::CString::new(std::fs::read_to_string(&filename)?)?;
        let mut translators = python_translators::PythonTranslator::new(&code.as_c_str())?;
        if translators.len() != 1 {
            eyre::bail!("Only one Python translator per file is supported for now");
        }
        let translator = translators.pop().unwrap();
        self.python_translator = Some((
            filename,
            translator.name(),
            AnyTranslator::Python(Arc::new(translator)),
        ));
        Ok(())
    }

    #[cfg(feature = "python")]
    pub fn has_python_translator(&self) -> bool {
        self.python_translator.is_some()
    }

    #[cfg(feature = "python")]
    pub fn reload_python_translator(&mut self) -> Result<()> {
        if let Some((path, _, _)) = self.python_translator.take() {
            self.load_python_translator(path)?;
        }
        Ok(())
    }
}

fn format(
    val: &ValueRepr,
    kind: ValueKind,
    subtranslator_name: &String,
    translators: &TranslatorList,
    subresults: &[HierFormatResult],
) -> Option<TranslatedValue> {
    match val {
        ValueRepr::Bit(val) => {
            let AnyTranslator::Basic(subtranslator) =
                translators.get_translator(subtranslator_name)
            else {
                panic!("Subtranslator '{subtranslator_name}' was not a basic translator");
            };

            Some(TranslatedValue::from_basic_translate(
                subtranslator.basic_translate(1, &VariableValue::String(val.to_string())),
            ))
        }
        ValueRepr::Bits(bit_count, bits) => {
            let AnyTranslator::Basic(subtranslator) =
                translators.get_translator(subtranslator_name)
            else {
                panic!("Subtranslator '{subtranslator_name}' was not a basic translator");
            };

            Some(TranslatedValue::from_basic_translate(
                subtranslator.basic_translate(*bit_count, &VariableValue::String(bits.clone())),
            ))
        }
        ValueRepr::String(sval) => Some(TranslatedValue {
            value: sval.clone(),
            kind,
        }),
        ValueRepr::Tuple => Some(TranslatedValue {
            value: format!(
                "({})",
                subresults
                    .iter()
                    .map(|v| v.this.as_ref().map_or("-", |t| t.value.as_str()))
                    .join(", ")
            ),
            kind,
        }),
        ValueRepr::Struct => Some(TranslatedValue {
            value: format!(
                "{{{}}}",
                subresults
                    .iter()
                    .map(|v| {
                        let n = v.names.join("_");
                        format!("{n}: {}", v.this.as_ref().map_or("-", |t| t.value.as_str()))
                    })
                    .join(", ")
            ),
            kind,
        }),
        ValueRepr::Array => Some(TranslatedValue {
            value: format!(
                "[{}]",
                subresults
                    .iter()
                    .map(|v| v.this.as_ref().map_or("-", |t| t.value.as_str()))
                    .join(", ")
            ),
            kind,
        }),
        ValueRepr::NotPresent => None,
        ValueRepr::Enum { idx, name } => Some(TranslatedValue {
            value: format!(
                "{name}{{{}}}",
                subresults[*idx]
                    .this
                    .as_ref()
                    .map_or("-", |t| t.value.as_str())
            ),
            kind,
        }),
        ValueRepr::Event => Some(TranslatedValue {
            value: "Event".to_string(),
            kind,
        }),
    }
}

#[local_impl::local_impl]
impl TranslationResultExt for TranslationResult {
    fn sub_format(
        &self,
        formats: &[crate::displayed_item::FieldFormat],
        translators: &TranslatorList,
        path_so_far: &[String],
    ) -> Vec<HierFormatResult> {
        self.subfields
            .iter()
            .map(|res| {
                let sub_path = path_so_far
                    .iter()
                    .chain([&res.name])
                    .cloned()
                    .collect::<Vec<_>>();

                let sub = res.result.sub_format(formats, translators, &sub_path);

                // we can consistently fall back to the default here since sub-fields
                // are never checked for their preferred translator
                let translator_name = formats
                    .iter()
                    .find(|e| e.field == sub_path)
                    .map(|e| e.format.clone())
                    .unwrap_or(translators.default.clone());
                let formatted = format(
                    &res.result.val,
                    res.result.kind,
                    &translator_name,
                    translators,
                    &sub,
                );

                HierFormatResult {
                    this: formatted,
                    names: sub_path,
                    fields: sub,
                }
            })
            .collect::<Vec<_>>()
    }

    /// Flattens the translation result into path, value pairs
    fn format_flat(
        &self,
        root_format: &Option<String>,
        formats: &[crate::displayed_item::FieldFormat],
        translators: &TranslatorList,
    ) -> Vec<SubFieldFlatTranslationResult> {
        let sub_result = self.sub_format(formats, translators, &[]);

        // FIXME for consistency we should not fall back to `translators.default` here, but fetch the
        // preferred translator - but doing that ATM will break if the spade translator is used, since
        // on the first render the spade translator seems to not have loaded its information yet.
        let formatted = format(
            &self.val,
            self.kind,
            root_format.as_ref().unwrap_or(&translators.default),
            translators,
            &sub_result,
        );

        let formatted = HierFormatResult {
            names: vec![],
            this: formatted,
            fields: sub_result,
        };
        let mut collected = vec![];
        formatted.collect_into(&mut collected);
        collected
    }
}

#[local_impl::local_impl]
impl VariableInfoExt for VariableInfo {
    fn get_subinfo(&self, path: &[String]) -> &VariableInfo {
        match path {
            [] => self,
            [field, rest @ ..] => match self {
                VariableInfo::Compound { subfields } => subfields
                    .iter()
                    .find(|(f, _)| f == field)
                    .unwrap()
                    .1
                    .get_subinfo(rest),
                VariableInfo::Bits => panic!(),
                VariableInfo::Bool => panic!(),
                VariableInfo::Clock => panic!(),
                VariableInfo::String => panic!(),
                VariableInfo::Real => panic!(),
                VariableInfo::Event => panic!(),
            },
        }
    }

    fn has_subpath(&self, path: &[String]) -> bool {
        match path {
            [] => true,
            [field, rest @ ..] => match self {
                VariableInfo::Compound { subfields } => subfields
                    .iter()
                    .find(|&(f, _)| f == field)
                    .is_some_and(|(_, info)| info.has_subpath(rest)),
                _ => false,
            },
        }
    }
}

#[local_impl::local_impl]
impl ValueKindExt for ValueKind {
    fn color(&self, user_color: Color32, theme: &SurferTheme) -> Color32 {
        match self {
            ValueKind::HighImp => theme.variable_highimp,
            ValueKind::Undef => theme.variable_undef,
            ValueKind::DontCare => theme.variable_dontcare,
            ValueKind::Warn => theme.variable_undef,
            ValueKind::Custom(custom_color) => *custom_color,
            ValueKind::Weak => theme.variable_weak,
            ValueKind::Error => theme.accent_error.background,
            ValueKind::Normal => user_color,
            ValueKind::Event => theme.variable_event,
        }
    }
}

pub struct StringTranslator {}

impl Translator<VarId, ScopeId, Message> for StringTranslator {
    fn name(&self) -> String {
        "String".to_string()
    }

    fn translate(
        &self,
        _variable: &VariableMeta,
        value: &VariableValue,
    ) -> Result<TranslationResult> {
        match value {
            VariableValue::BigUint(b) => Ok(TranslationResult {
                val: ValueRepr::String(format!("ERROR (0x{b:x})")),
                kind: ValueKind::Warn,
                subfields: vec![],
            }),
            VariableValue::String(s) => Ok(TranslationResult {
                val: ValueRepr::String((*s).to_string()),
                kind: ValueKind::Normal,
                subfields: vec![],
            }),
        }
    }

    fn variable_info(&self, _variable: &VariableMeta) -> Result<VariableInfo> {
        Ok(VariableInfo::String)
    }

    fn translates(&self, variable: &VariableMeta) -> Result<TranslationPreference> {
        if variable.encoding == VariableEncoding::String {
            Ok(TranslationPreference::Prefer)
        } else {
            Ok(TranslationPreference::No)
        }
    }
}

fn check_single_wordlength(num_bits: Option<u32>, required: u32) -> Result<TranslationPreference> {
    if Some(required) == num_bits {
        Ok(TranslationPreference::Yes)
    } else {
        Ok(TranslationPreference::No)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn check_single_wordlength_exact_match() {
        let result = check_single_wordlength(Some(32), 32).unwrap();
        assert_eq!(result, TranslationPreference::Yes);
    }

    #[test]
    fn check_single_wordlength_mismatch() {
        let result = check_single_wordlength(Some(64), 32).unwrap();
        assert_eq!(result, TranslationPreference::No);
    }

    #[test]
    fn check_single_wordlength_none() {
        let result = check_single_wordlength(None, 32).unwrap();
        assert_eq!(result, TranslationPreference::No);
    }

    #[test]
    fn translator_list_basic_operations() {
        let translators = all_translators();

        // Check that we have some translators
        assert!(!translators.all_translator_names().is_empty());

        // Check default translator exists
        assert!(
            translators
                .all_translator_names()
                .contains(&translators.default.as_str())
        );

        // Check we can get a translator by name
        let hex_translator = translators.get_translator("Hexadecimal");
        assert_eq!(hex_translator.name(), "Hexadecimal");

        // Check basic translator names subset
        let basic_names = translators.basic_translator_names();
        assert!(basic_names.contains(&"Hexadecimal"));
        assert!(basic_names.contains(&"Binary"));
    }

    #[test]
    fn variable_info_has_subpath() {
        use surfer_translation_types::VariableInfo;

        let info = VariableInfo::Compound {
            subfields: vec![
                ("field1".to_string(), VariableInfo::Bits),
                (
                    "field2".to_string(),
                    VariableInfo::Compound {
                        subfields: vec![("nested".to_string(), VariableInfo::Bool)],
                    },
                ),
            ],
        };

        assert!(info.has_subpath(&[]));
        assert!(info.has_subpath(&["field1".to_string()]));
        assert!(info.has_subpath(&["field2".to_string()]));
        assert!(info.has_subpath(&["field2".to_string(), "nested".to_string()]));
        assert!(!info.has_subpath(&["nonexistent".to_string()]));
        assert!(!info.has_subpath(&["field2".to_string(), "nonexistent".to_string()]));
    }
}